Use cmdline instead of comm, in terminal detection #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtcdr
reviewed
Mar 2, 2023
| @@ -404,35 +413,50 @@ impl GeneralReadout for LinuxGeneralReadout { | |||
| } | |||
| } | |||
|
|
|||
| fn terminal_exec(pid: i32) -> String { | |||
There was a problem hiding this comment.
terminal_name seems more appropriate here.
|
|
||
| let mut terminal_name = terminal_exec(terminal_pid); | ||
| if terminal_name.is_empty() { | ||
| return "".to_string(); |
There was a problem hiding this comment.
Can you use String::new() instead?
Comment on lines
+382
to
+390
| // fn terminal(&self) -> Result<String, ReadoutError> { | ||
| // use terminfo::Database; | ||
| // | ||
| // let db = Database::from_env() | ||
| // let term = db.name(); | ||
| // | ||
| // Ok(term.to_string()) | ||
| // } | ||
|
|
There was a problem hiding this comment.
Can you please remove this commented function?
| @@ -25,6 +25,7 @@ features = ["build","cargo","git","rustc"] | |||
| dirs = "4.0" | |||
| walkdir = "2.3.2" | |||
| os-release = "0.1" | |||
| terminfo = "0.7" | |||
There was a problem hiding this comment.
It looks like you forgot to remove this dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: Macchina-CLI/macchina#272
Doesn't work in nix-shells in my testing