Add lastError function #3654
Draft
Add lastError function #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets lastError, so use it for constructing all errors except control transferring errors like return, continue, etc.
Also set position for suppressed errors
In particular, we previously constructed the error message when returning with it (when stopIfError/returnIfError true). Now we always construct it (so it gets saved to lastError), but only return with it in those cases.
Also remove a bunch of cruft in the file error-messages.m2
mahrud
reviewed
Feb 12, 2025
| e(x,p1,h1) | ||
| f(x,p1,h1) | ||
| g(x,p1,h1) | ||
| assert((last try 1/0 else lastError()) == "division by zero") |
There was a problem hiding this comment.
Are you planning on replacing the manual tests above with automatic versions?
|
I did something similar on my dev branch. I'll compare the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns a sequence containing the location and message string for the last error (at least most of the time, e.g., not for syntax errors).
The eventual goal is to use this in the MPI package (see #2129) for handling errors gracefully, e.g., doing something like
try x else lastError().