Specify doc nodes from Varieties package #3642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was Core#"preloaded packages", which the user can modify.
Otherwise, loading Macaulay2Doc may fail if Varieties isn't pre-loaded.
Not necessarily loaded already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Macaulay2Doc exports
Core#"preloaded packages", but the user can change that ininit.m2since #3312. So it's not guaranteed that any particular package is preloaded.However, there were several links in Macaluay2Doc that pointed to Varieties doc nodes. So loading Macaulay2Doc was failing when Varieties wasn't preloaded.
We add
"Varieties::"in front of these links to fix this. We also drop thePackageExportsoption from Macaulay2Doc since it isn't necessary and was unpredictable.Note that
(betti, CoherentSheaf)is linked to frombettibut is undocumented. I went ahead and updated it like the others so that it should work whenever it is eventually documented.