Setup ESLint in order to lint JavaScript #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(maybe also something for another PR?)
Splines
added
the
CI/CD
Splines
changed the title
Splines
force-pushed
the
lint/js
branch
6 times, most recently
from
b41e342 to
425a27e
Compare
Splines
changed the title
Splines
changed the title
Splines
changed the title
Splines
changed the title
fosterfarrell9
approved these changes
Dec 13, 2023
This was referenced Dec 19, 2023
Splines
added a commit
that referenced
this pull request
Jan 6, 2024
* Init new ESLint config to lint .js and .js.erb files * Add default settings/extensions for VSCode (maybe also something for another PR?) * Add ESLint to CI/CD * Introduce dummy changes to see ESLint in action * Fix wrong fetch depth for checkout action * Remove unnecessary "--" to pass arguments * Outsource retrieval of changed files to reusable action * Correct location of reusable action * Fix further stuff related to GitHub action * Clean up GitHub Actions files * Cache global yarn cache directory * Remove VSCode specific settings in favor of #569 * Revert "Introduce dummy changes to see ESLint in action" This reverts commit cdf3473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ESLint to our CI/CD pipeline and checks for linting violations in all changed
.jsand.js.erbfiles.Adding a sensible VSCode
settings.jsonwas outsourced to #569Sample output
See
this runthis run. The following screenshot was recorded in theFiles changedtab on GitHub.