Résolution du bug de diffusion des préavis quand un numéro de télépho…

…ne ou un email est un string vide (#3574) ## Linked issues - Resolve #3573
MTES-MCT · Aug 23, 2024 · 5ac0b55 · 5ac0b55
2 parents 89ab58d + 85a8bcf
commit 5ac0b55
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/datascience/src/pipeline/shared_tasks/control_units.py b/datascience/src/pipeline/shared_tasks/control_units.py
@@ -32,11 +32,15 @@ def fetch_control_units_contacts() -> pd.DataFrame:
         .reset_index(drop=True)
     )
     contacts["email"] = contacts["control_unit_contacts"].apply(
-        lambda x: x.get("email") if x.get("isEmailSubscriptionContact") else None
+        lambda x: x.get("email")
+        if x.get("email") and x.get("isEmailSubscriptionContact")
+        else None
     )
 
     contacts["phone"] = contacts["control_unit_contacts"].apply(
-        lambda x: x.get("phone") if x.get("isSmsSubscriptionContact") else None
+        lambda x: x.get("phone")
+        if x.get("phone") and x.get("isSmsSubscriptionContact")
+        else None
     )
 
     email_and_phone_contacts = (

diff --git a/datascience/tests/test_pipeline/conftest.py b/datascience/tests/test_pipeline/conftest.py
@@ -92,6 +92,15 @@ def monitorenv_control_units_api_response() -> list:
                     "name": "OPERATIONAL_CENTER_HO",
                     "phone": "xx xx xx xx xx",
                 },
+                {
+                    "id": 951357,
+                    "controlUnitId": 2,
+                    "email": "unused_email.adresse@somewhere",
+                    "isEmailSubscriptionContact": False,
+                    "isSmsSubscriptionContact": True,
+                    "name": "OPERATIONAL_CENTER_HO",
+                    "phone": "",
+                },
             ],
             "isArchived": False,
             "name": "Unité 2",
@@ -231,6 +240,7 @@ def monitorenv_control_units_api_response() -> list:
                 {
                     "id": 1541,
                     "controlUnitId": 6,
+                    "email": "",
                     "isEmailSubscriptionContact": True,
                     "isSmsSubscriptionContact": False,
                     "name": "Référent police",