Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brief] Ajout d'un webworker et correction du zoom dans le chargement des images #2058

Merged

Conversation

maximeperraultdev
Copy link
Collaborator

@maximeperraultdev maximeperraultdev commented Jan 29, 2025

What have I done in this PR:

  • Refacto ExportImagesLayer to a hook => useExportImages
  • Extract pdf creation to a webworker
  • Button has 2 loading states: "chargement des images" & "chargement du brief"
  • Brief : add wrapping onto reporting theme/subtheme

Limitation : webworker has not access to DOM

Related Pull Requests & Issues


  • Tests E2E (Cypress)

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/dashboard/use_web_worker_to_create_pdf branch from 10aa470 to 799bed4 Compare January 29, 2025 09:50
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/dashboard/use_web_worker_to_create_pdf branch from 7a34221 to 3e07650 Compare January 29, 2025 12:29
@maximeperraultdev maximeperraultdev merged commit 5b2f99c into main Jan 30, 2025
27 checks passed
@maximeperraultdev maximeperraultdev deleted the maxime/feat/dashboard/use_web_worker_to_create_pdf branch January 30, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants