Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tableau de bord] Épingler en groupe #2040

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

maximeperraultdev
Copy link
Collaborator

Related Pull Requests & Issues


  • Tests E2E (Cypress)

return (
<>
<Icon.PinFilled color={THEME.color.blueGray} title="Désélectionner tous" />
Désélectionner tous
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'après le ticket le wording serait plutôt : Tout sélectionner et Tous désélectionner

Copy link
Collaborator

@claire2212 claire2212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'il manque le fait d'avoir au niveau des groupes des couches (zones reg et AMP) l'icône qui est en sélection "partielle" avec juste le contour bleu

Capture d’écran 2025-01-24 à 15 31 05

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1988/selectall_by_bloc branch 3 times, most recently from 94be10c to 655cc2f Compare January 27, 2025 15:19
export const ResultNumber = styled.small`
font-size: 13px;
font-weight: regular;
color: ${THEME.color.slateGray};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu peux plutôt faire color: ${p => p.theme.color.slateGray};

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1988/selectall_by_bloc branch from 655cc2f to f306deb Compare January 28, 2025 08:09
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1988/selectall_by_bloc branch from f306deb to c04f154 Compare January 28, 2025 09:34
Copy link

@maximeperraultdev maximeperraultdev merged commit e1381aa into main Jan 28, 2025
26 checks passed
@maximeperraultdev maximeperraultdev deleted the maxime/feat/1988/selectall_by_bloc branch January 28, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tableau de bord - épingler en groupe
3 participants