Extend NASA GrIS regions into ocean #210
Conversation
alexolinhager
force-pushed
the
alexolinhager/geometric_features/add_oceanExtended_GrIS_regions
branch
4 times, most recently
from
43b1270 to
d483e79
Compare
alexolinhager
force-pushed
the
alexolinhager/geometric_features/add_oceanExtended_GrIS_regions
branch
from
d483e79 to
4b1670a
Compare
alexolinhager
force-pushed
the
alexolinhager/geometric_features/add_oceanExtended_GrIS_regions
branch
from
4b1670a to
6c3b455
Compare
There was a problem hiding this comment.
@alexolinhager I think this looks good. My only suggestion would be to change the names of the greenland regions aggregators so that the difference between the ocean and land ice ones are clear since both include land ice and continental shelf regions. Maybe "ISMIP6 Greenland" and "NASA Greenland"? https://github.com/MPAS-Dev/geometric_features/blob/main/geometric_features/aggregation/ocean/greenland_regions.py
Changes the names of the ISMIP6 and NASA greenland regions to make it easier to distinguish between the two
|
Thanks @cbegeman, that's a good suggestion. I just pushed a commit with a new naming convention |
|
@alexolinhager, I see that your features aren't using the geojson formatting that is standard here, you're using a more compact format that isn't as easy to read. Could you follow the second procedure here to merge them all into a single feature collection and then split them back out into individual features to clean things up? |
|
The important bit is: # split the feature collection back into individual features within
# ./geometric_data to clean things up
gf.split(fc)It looks like you have the tags in the database and all that. |
There was a problem hiding this comment.
@alexolinhager , this looks good. I just have a few minor suggestions.
I loaded all the new regions (green) into QGIS and overlaid the GIS outline (pink) and one of the ISMIP6 ocean regions (red) for comparison. The background is BedMachine bed topography colored between -2000 and 0 m. Everything looks as expected! This will be nice to have available.
geometric_features/aggregation/landice/nasa_greenland_extended.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@alexolinhager , thanks for making these adjustments. Looks good to me!
This PR introduces manually modified versions of the NASA GrIS in
geometric_data/landice/region(eastCentralGreenland1, etc.), so that each region now extends into the ocean to the continental shelf. The boundaries of some regions were also modified so one region flows into each fjord. For now, the PR adds the newly modified regions without replacing the originals in case existing analyses are dependent on these regions.