Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes to climatology maps of velocity #1053

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 18, 2025

The colormaps in difference plots are now being set.

Several docstrings and comments copied from SOSE have been fixed.

The name of the gallery group has been fixed for main vs. ctrl runs.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

The colormaps in difference plots are now being set.

Several docstrings and comments copied from SOSE have been fixed.

The name of the gallery group has been fixed for main vs. ctrl
runs.
@xylar xylar added the bug label Jan 18, 2025
@xylar xylar requested a review from cbegeman January 18, 2025 15:44
@xylar xylar self-assigned this Jan 18, 2025
@xylar
Copy link
Collaborator Author

xylar commented Jan 18, 2025

Testing

I ran the test suite on Chrysalis. Results are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/fix-velocity-difference-colormap/

The mesh_rename test didn't work but for reasons unrelated to this PR that I will address elsewhere. Update: this appears to just have been related to a bad node.

The main vs. ctrl run produced expected results:
image

Before, this plot looked like this:
image

The gallery group is now Global Velocity, (I removed Control: ctrl after the testing, so it is still there in the web pages above) whereas it was Global Control: ctrl before.

@xylar
Copy link
Collaborator Author

xylar commented Jan 18, 2025

@cbegeman, I ran across a few issues here while running tests for E3SM-Unified. I'd appreciate a quick review by inspection when you have a few minutes.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Thanks for fixing this! I noticed those issues but hadn't gotten around to addressing them.

@xylar
Copy link
Collaborator Author

xylar commented Jan 21, 2025

@cbegeman, thanks for having a look!

@xylar xylar merged commit 2340566 into MPAS-Dev:develop Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants