Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prt): fix fpe by constraining local z coord to unit interval #2183

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jan 31, 2025

In the generalized particle tracking method, a local Z coordinate could be calculated to fall slightly outside of the unit interval due to numerical imprecision. This could cause the vertical travel time calculation to fail with a floating point exception. Constrain the local Z coordinate to the unit interval to prevent this.


Checklist of items for pull request

  • Replaced section above with description of pull request
  • Closes PRT error: floating divide by zero in subcell ternary method #2179
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli marked this pull request as ready for review January 31, 2025 17:59
@wpbonelli wpbonelli merged commit 42cdc58 into MODFLOW-ORG:develop Jan 31, 2025
20 checks passed
@wpbonelli wpbonelli deleted the 2179 branch January 31, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRT error: floating divide by zero in subcell ternary method
1 participant