Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gwe-est): add support for energy decay in the solid phase #2155

Merged
merged 18 commits into from
Jan 31, 2025
Merged

fix(gwe-est): add support for energy decay in the solid phase #2155

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
20ae3f1
fix(gwe-est): add support for energy decay in the solid phase
emorway-usgs Jan 21, 2025
8dfc1c3
different implementation of new variable idcytype
emorway-usgs Jan 21, 2025
dee2812
rename variable to something more indicative of what it is doing
emorway-usgs Jan 21, 2025
378ed15
Set a tolerance for value comparisons to 1e-10
emorway-usgs Jan 21, 2025
e9c1cbd
add latex escape character before underscores
emorway-usgs Jan 21, 2025
ae887bd
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 29, 2025
a853d93
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 29, 2025
1f51717
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 29, 2025
8e3021e
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 29, 2025
6a93a3e
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 29, 2025
bf91985
Fix unused variable error
emorway-usgs Jan 30, 2025
f5c2c94
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 30, 2025
2dc749c
Fixed for review comment https://github.com/MODFLOW-USGS/modflow6/pul…
emorway-usgs Jan 30, 2025
179b7de
New test in response to https://github.com/MODFLOW-USGS/modflow6/pull…
emorway-usgs Jan 30, 2025
495132e
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 30, 2025
c52ed0e
Adjustments applied in response to https://github.com/MODFLOW-USGS/mo…
emorway-usgs Jan 30, 2025
eb62e82
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 30, 2025
b7a2330
Fix for review comment https://github.com/MODFLOW-USGS/modflow6/pull/…
emorway-usgs Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autotest/test_gwe_decay02.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ def add_gwe(sim, gwename, add_esl=False):
zero_order_decay_water = False
zero_order_decay_solid = False

esl_amt = n * gamma_w + (1 - n) * gamma_s * rho_s
esl_spd = {
0: [[(0, 0, 0), 400]],
0: [[(0, 0, 0), abs(esl_amt)]],
}
esl = flopy.mf6.ModflowGweesl(
gwe,
Expand Down
Loading