Fix permissions for the Pages section of the admin console. Closes #2060. #2140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2060, there is a bug the "Pages" permissions. Currently, it is not possible to assign users the correct permissions to view the Pages tabs in the console.
There are two issues:
user.change_staticpage
anduser.change_frontpagebutton
permissions, which don't exist. These permissions belong to thephysionet
app, notusers
.view_redirects
view is restricting access to aphysionet.view_redirect
permission, which doesn't exist. The redirect permission belongs to Django'sredirects
app.Side note, but it isn't ideal that the navbar logic displays all three subitems {% if perms.physionet.change_staticpage or perms.physionet.change_frontpagebutton or perms.redirect.view_redirect %}, even if the user only has permission to view/edit one of the subitems. I think we can worry about this later.
It might be cleaner to display all tabs/pages admin users, even if the user doesn't have permission to edit/view the page. This way the user knows what functionality exists, and they can request access if needed.