Add "legacy" parameter to PublishedProject.zip_name #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to avoid including the project title in zip file names as well as in the zip file contents, in favor of the project slug, which is more stable and machine-readable. Eventually, therefore, the behavior of the zip_name function should be changed; as a first step in that direction, add an optional argument so callers can specify whether they want the old or new style. Existing code continues to use the old style for now.
|
Thanks, looks good! As next steps, could we:
We can discuss at: #1674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to avoid including the project title in zip file names as well as in the zip file contents, in favor of the project slug, which is more stable and machine-readable. (See issue #1674 for more background.)
Eventually, therefore, the behavior of the zip_name function should be changed; as a first step in that direction, add an optional argument so callers can specify whether they want the old or new style.
Existing code continues to use the old style for now, but when we upload zip files to S3 I'd like to rename the zip files to the new style (see issue #2122). Adding the code in PublishedProject should make that easier and cleaner, and allow the rest of the site to be migrated eventually.