Fix security bugs in edit_files_panel #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When text is included as a string in an inline JavaScript expression, it must be escaped. Currently, the upload form does not permit creating files or directories with names containing quotes or control characters, but the templates should nonetheless protect against that possibility.
|
Yoiks, good catch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to pull #2111, I noted that the
edit_files_panelhas the same security problem as the oldfiles_panel.(This affects the
project_filesview as well ascopyedit_submission.)For example, in
media/active-projects/SHuKI1APLrwWCqxSQnSk, try renamingsubject-100tosubject-100'+alert('Hello world')+'. Then go to the project files page (not the preview; that bug has now been fixed) and click the corresponding link.