Merge pull request #2108 from MIT-LCP/console-testurls

TestURLs coverage for (most of) console
MIT-LCP · Oct 16, 2023 · a7822f1 · a7822f1
2 parents 6a5aa58 + 87f68dc
commit a7822f1
Show file tree

Hide file tree

Showing 2 changed files with 107 additions and 1 deletion.
diff --git a/physionet-django/console/urls.py b/physionet-django/console/urls.py
@@ -157,3 +157,106 @@
     path('event_agreements/<int:pk>/new-version/', views.event_agreement_new_version,
          name='event_agreement_new_version'),
 ]
+
+# Parameters for testing URLs (see physionet/test_urls.py)
+TEST_DEFAULTS = {
+    '_user_': 'admin',
+    'button_pk': 1,
+    'event_slug': 'iLII4L9jSDFh',
+    'page_pk': 2,
+    'pk': 1,
+    'pid': 1,
+    'section_pk': 1,
+    'news_id': 1,
+    'username': 'rgmark',
+}
+TEST_CASES = {
+    'manage_published_project': {
+        'project_slug': 'demoeicu',
+        'version': '2.0.0',
+    },
+
+    'project_access_requests_detail': {
+        # id of a PublishedProject with access_policy=CONTRIBUTOR_REVIEW
+        'pk': 4,
+    },
+
+    'submission_info_redirect': {
+        'project_slug': 'p7TCIMkltNswuOB9FZH1',
+    },
+    'submission_info': {
+        'project_slug': 'p7TCIMkltNswuOB9FZH1',
+    },
+    # Missing demo data (projects in appropriate submission states)
+    'edit_submission': {
+        'project_slug': 'xxxxxxxxxxxxxxxxxxxx',
+        '_skip_': True,
+    },
+    'copyedit_submission': {
+        'project_slug': 'xxxxxxxxxxxxxxxxxxxx',
+        '_skip_': True,
+    },
+    'awaiting_authors': {
+        'project_slug': 'xxxxxxxxxxxxxxxxxxxx',
+        '_skip_': True,
+    },
+    'publish_submission': {
+        'project_slug': 'xxxxxxxxxxxxxxxxxxxx',
+        '_skip_': True,
+    },
+    'publish_slug_available': {
+        '_user_': 'tompollard',
+        'project_slug': 'p7TCIMkltNswuOB9FZH1',
+        '_query_': {'desired_slug': 'note-parser'},
+    },
+
+    'credential_applications': [
+        # categories defined in views.credential_applications()
+        {'status': 'successful'},
+        {'status': 'unsucccessful'},
+        {'status': 'pending'},
+    ],
+
+    'view_credential_application': {
+        # slug of a CredentialApplication with any status
+        'application_slug': '5rDeC8Om9dBJTeJN91y2',
+    },
+    'process_credential_application': {
+        # slug of a CredentialApplication with status=PENDING
+        'application_slug': '5rDeC8Om9dBJTeJN91y2',
+    },
+
+    'training_list': [
+        # categories defined in views.training_list()
+        {'status': 'review'},
+        {'status': 'valid'},
+        {'status': 'expired'},
+        {'status': 'rejected'},
+    ],
+    'training_process': {
+        # id of a Training with status=REVIEW
+        'pk': 2,
+    },
+
+    'user_group': {
+        # name of a Group
+        'group': 'Managing%20Editor',
+    },
+    'users': [
+        # categories defined in views.users()
+        {'group': 'all'},
+        {'group': 'admin'},
+        {'group': 'active'},
+        {'group': 'inactive'},
+    ],
+
+    # Missing demo data
+    'event_agreement_detail': {'_skip_': True},
+    'event_agreement_delete': {'_skip_': True},
+    'event_agreement_new_version': {'_skip_': True},
+
+    # Broken views: POST required for no reason
+    'users_list_search': {'group': 'all', '_skip_': True},
+    'known_references_search': {'_skip_': True},
+    'news_search': {'_skip_': True},
+}
diff --git a/physionet-django/console/views.py b/physionet-django/console/views.py
@@ -1991,7 +1991,10 @@ def credentialing_stats(request):
         a = acc_and_rej.filter(status=CredentialApplication.Status.ACCEPTED).count()
         r = acc_and_rej.filter(status=CredentialApplication.Status.REJECTED).count()
         stats[y]['processed'] = a + r
-        stats[y]['approved'] = round((100 * a) / (a + r))
+        try:
+            stats[y]['approved'] = round((100 * a) / (a + r))
+        except ZeroDivisionError:
+            stats[y]['approved'] = None
 
     # Time taken to contact the reference
     time_to_ref = apps.annotate(tm=Cast(F('reference_contact_datetime')