Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble sort #19

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Bubble sort #19

merged 9 commits into from
Jan 8, 2025

Conversation

oleksandr-maksymikhin
Copy link

This pull request includes implementation of Bubble sort algorithm:

  1. Implementation of bubble sort algorithm is in solutions/bubble_sort.py
  2. Unit tests are in solutions/tests/ test_bubble_sort.py
  3. Passed automation checks (pydoc, doctest, unittest)

Please review the solution and let me know if any corrections are needed.

created structure of files
completed docstring
sort collection of type(int) with tests coverage
Extended parameter data types. Now module works with (int, char, string, bool). Tests cover all data types (int, char, string, bool)
…us collection). Small corrections by commets and variable names
@oleksandr-maksymikhin oleksandr-maksymikhin added the code challenge challenge for CDS program label Jan 3, 2025
@oleksandr-maksymikhin oleksandr-maksymikhin self-assigned this Jan 3, 2025
@emrebiyik emrebiyik self-assigned this Jan 3, 2025
@emrebiyik emrebiyik removed their assignment Jan 4, 2025
solutions/bubble_sort.py Outdated Show resolved Hide resolved
solutions/tests/test_bubble_sort.py Show resolved Hide resolved
Added input types verification/ Processed types (int, float, str, bool)
Copy link

@emrebiyik emrebiyik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done, and thank you for your effort. Approved!

solutions/bubble_sort.py Show resolved Hide resolved
solutions/tests/test_bubble_sort.py Show resolved Hide resolved
@emrebiyik emrebiyik merged commit 69a878a into main Jan 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code challenge challenge for CDS program
Projects
Development

Successfully merging this pull request may close these issues.

2 participants