Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker Error Message #792

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Conversation

ChrisZYJ
Copy link
Contributor

@ChrisZYJ ChrisZYJ commented Jan 25, 2025

Description

Makes case file error messages clearer and more obvious

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Something else

@ChrisZYJ ChrisZYJ requested review from a team and sbryngelson as code owners January 25, 2025 09:01
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 43.72%. Comparing base (f1582f6) to head (9e1ecdb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/common/m_helper.fpp 0.00% 5 Missing ⚠️
src/common/m_checker_common.fpp 0.00% 4 Missing ⚠️
src/common/m_mpi_common.fpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   43.73%   43.72%   -0.01%     
==========================================
  Files          65       65              
  Lines       19042    19035       -7     
  Branches     2324     2331       +7     
==========================================
- Hits         8328     8324       -4     
+ Misses       9307     9304       -3     
  Partials     1407     1407              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

This was intentional. I don't like the use of long strings of characters because how they appears will depend on the width of your terminal and its font. It seems very old school and somehow bothers me. It also makes it harder to check for such patterns in the future, since I do it via grep in CI. I'm open to alternative ways to make the printing of case file errors more readable, but don't want to introduce long patterns of ---- or ===== or !!!!!!. Does that make sense?

@ChrisZYJ ChrisZYJ requested a review from a team as a code owner January 25, 2025 23:08
@ChrisZYJ
Copy link
Contributor Author

Thanks for teaching me good coding practices! I've moved the --- and reverted my changes to your grep implementation. It now formats the Fortran output messages better and emphasizes them using colors in Mako. Please let me know if this is better.

@ChrisZYJ ChrisZYJ changed the title Checker Error Message Lines Checker Error Message Jan 25, 2025
@sbryngelson sbryngelson merged commit 43812d8 into MFlowCode:master Jan 26, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants