Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增插件botkikai #454

Merged
merged 1 commit into from
Jan 26, 2025
Merged

新增插件botkikai #454

merged 1 commit into from
Jan 26, 2025

Conversation

RayanceKing
Copy link
Contributor

已经完善许可协议和readme链接


@github-actions github-actions bot added the plugins Plugin modifications label Jan 20, 2025
Copy link

Thanks for your contribution! 🎉
Please be patient before we done checking. If you've added or modified plugins, a brief report will be generated below.
Have a nice day!

# 合并前检查单(供仓库维护者参考)
- *插件适合提交;
- 提交者有权提交;
- 所提交信息完整有效;
- 插件分类正确,名称、介绍和说明符合要求。
详见贡献指南

Copy link

Last updated at: 2025-01-20 12:01:04 (UTC+8)
Add label recheck to regenerate manually

Plugin Validation Report

botkikai

Info Value Valid
URL RayanceKing/MCDR-BotKikai@master
Authors Jerry-FaGe, RayanceKing -
Labels Tool Management -
Introduction zh_cn
Meta mcdreforged.plugin.json
Latest Release None ⚠️
Meta Value
Name BotKikai
Version 0.0.2
Authors RayanceKing, Jerry-FaGe
Description en_us 适用于MCDR的将假人存储至列表并提供指令映射,便捷放置,操作界面等功能的插件。

@alex3236
Copy link
Member

alex3236 commented Jan 20, 2025

没有必要重开PR…
Bot 的协议是 GPL3,如果用了代码,需要使用相同协议
另外你这个 fork 似乎改的不怎么干净,命令仍是手解 info,逻辑改的也不多,建议完善后再来

fyi (贡献指南):

  • 对于开源代码,请务必遵守相应的开源许可证;
  • 你的项目准备好进入公众测试(Beta)阶段了吗?——如果它还处于早期版本,请先将其完善。我们建议您在提交时保证插件已有一个可用 Release。

只是个人建议,你也可以等其他维护者合(

@AnzhiZhang
Copy link
Member

手解不是大问题,功能完善就可以了吧。协议如果发现了不规范使用,不能合并

Copy link
Member

@alex3236 alex3236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎已经改了,现在问题不大
(注意无 Release 时用户无法通过插件库下载此插件

@AnzhiZhang AnzhiZhang merged commit f5a4005 into MCDReforged:master Jan 26, 2025
3 checks passed
Copy link

Well done! 🎉

Your pull request has been successfully merged.

We appreciate your hard work and valuable input. If you have any further questions or need additional changes, feel free to reach out.

Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Plugin modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants