Skip to content

Commit

Permalink
LM-3196 fixed ClientSettingsCashoutBlockUpdated handling
Browse files Browse the repository at this point in the history
  • Loading branch information
KonstantinRyazantsev committed Mar 23, 2024
1 parent 69f549f commit bc495b4
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/HftApi/HftApi.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="Lykke.Messaging.RabbitMq" Version="2.2.2" />
<PackageReference Include="Lykke.Service.Balances.Client" Version="2.3.2" />
<PackageReference Include="Lykke.Service.ClientDialogs.Client" Version="1.0.1" />
<PackageReference Include="Lykke.Service.HftInternalService.Client" Version="2.5.0" />
<PackageReference Include="Lykke.Service.HftInternalService.Client" Version="2.6.1" />
<PackageReference Include="Lykke.Service.Kyc.Client" Version="1.5.0" />
<PackageReference Include="Lykke.Service.Operations.Client" Version="3.1.0" />
<PackageReference Include="Lykke.Service.Operations.Contracts" Version="3.1.1" />
Expand Down
12 changes: 4 additions & 8 deletions src/HftApi/RabbitSubscribers/ClientSettingsUpdatesSubscriber.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,35 +54,31 @@ public async Task HandleMessage(ClientSettingsCashoutBlockUpdated evt)
ClientId = evt.ClientId
});

var enabledClientApiKeys = await _hftInternalClient.Keys.GetKeys(evt.ClientId);
var enabledClientApiKeys = await _hftInternalClient.Keys.GetKeysSensitive(evt.ClientId);

if (evt.TradesBlocked)
{
foreach (var key in enabledClientApiKeys)
{
_tokenService.Remove(key.Id);

var apiKeyStart = key.ApiKey.Substring(0, 4);

_log.Info($"API key has been cached", context: new
{
ClientId = evt.ClientId,
ApiKeyStart = apiKeyStart
ApiKeyId = key.Id
});
}
}
else
{
foreach (var key in enabledClientApiKeys)
{
_tokenService.Add(key.ApiKey);

var apiKeyStart = key.ApiKey.Substring(0, 4);
_tokenService.Add(key.Id);

_log.Info($"API key has been evicted from the cache", context: new
{
ClientId = evt.ClientId,
ApiKeyStart = apiKeyStart
ApiKeyId = key.Id
});
}
}
Expand Down
7 changes: 3 additions & 4 deletions src/HftApi/RabbitSubscribers/KeyUpdateSubscriber.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,12 @@ private async Task ProcessMessageAsync(KeyUpdatedEvent message)
// that it's acceptable since these events are not very frequent

var isClientBlocked = await _blockedClients.IsClientBlocked(message.ClientId);
var apiKeyStart = message.Id.Substring(0, 4);

_log.Info($"API key deleted: {message.IsDeleted}. Client blocked: {isClientBlocked}", context: new
{
ClientId = message.ClientId,
WalletId = message.WalletId,
ApiKeyStart = apiKeyStart
ApiKeyId = message.Id
});

if (!message.IsDeleted && !isClientBlocked)
Expand All @@ -76,7 +75,7 @@ private async Task ProcessMessageAsync(KeyUpdatedEvent message)
{
ClientId = message.ClientId,
WalletId = message.WalletId,
ApiKeyStart = apiKeyStart
ApiKeyId = message.Id
});
}
else
Expand All @@ -87,7 +86,7 @@ private async Task ProcessMessageAsync(KeyUpdatedEvent message)
{
ClientId = message.ClientId,
WalletId = message.WalletId,
ApiKeyStart = apiKeyStart
ApiKeyId = message.Id
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Lykke.HftApi.Services/Lykke.HftApi.Services.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<PackageReference Include="Lykke.Cqrs" Version="9.0.1" />
<PackageReference Include="Lykke.MatchingEngineConnector" Version="8.6.0" />
<PackageReference Include="Lykke.Service.ClientDialogs.Client" Version="1.0.1" />
<PackageReference Include="Lykke.Service.HftInternalService.Client" Version="2.5.0" />
<PackageReference Include="Lykke.Service.HftInternalService.Client" Version="2.6.1" />
<PackageReference Include="Lykke.Service.Operations.Client" Version="3.1.0" />
<PackageReference Include="Lykke.Service.Operations.Contracts" Version="3.1.1" />
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="5.0.0" />
Expand Down

0 comments on commit bc495b4

Please sign in to comment.