Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mixins): enable passing extra transitionable props to some mixins #3430

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Feb 4, 2025

Some of our mixins have inbuilt transitions.
Sometimes the consumer has to override everything, which will either

  • result in a really poor animation
  • or a lot of repeated code

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@Kiarokh Kiarokh self-assigned this Feb 4, 2025
@Kiarokh Kiarokh force-pushed the mixin-clickable-transitions branch from 68e07db to 8944b4a Compare February 4, 2025 13:02
Copy link

github-actions bot commented Feb 4, 2025

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3430/

Copy link
Contributor

@adrianschmidt adrianschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianschmidt adrianschmidt merged commit 30a4a4e into main Feb 4, 2025
12 checks passed
@adrianschmidt adrianschmidt deleted the mixin-clickable-transitions branch February 4, 2025 15:06
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.81.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants