refactor(table): use an SCSS variable for the height of aggregations row #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, a table loads, but the aggregation row is not shown. That is because the component does real-time (but delayed) calculations and adds classes or inlined styles. In this case, the previous code was written relying on existence of a class name called `has-aggregations`. But this class would be applied to the table, unless some re-rendering happened; and sometimes it was remove when some re-rendering happened (e.g. a column was moved). This caused the styles that are depending on the class name to have no effect, causing the aggregations row to be covered and hidden by the rest of the table.
Kiarokh
force-pushed
the
table-aggregations-row
branch
from
9638ba3 to
32f2e2e
Compare
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3429/ |
LucyChyzhova
approved these changes
Feb 4, 2025
|
🎉 This PR is included in version 37.81.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://product.lime-crm.com/client/object/bug/7808?tab=_overview
The summary/aggregation of the column is not shown correctly. The number is being cut, not being readable.A lot of costumers reaching out about this., see example pic
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: