Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper classes for internal use in limel-markdown #3408

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Jan 20, 2025

fix https://github.com/Lundalogik/crm-feature/issues/4577

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@Kiarokh Kiarokh changed the title chore(markdown): move truncate-paragraphs helper class to the botto… add helper classes for internal use in limel-markdown Jan 20, 2025
Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3408/

@Kiarokh Kiarokh force-pushed the markdown-inline-elements branch 2 times, most recently from 70f5623 to b244bc8 Compare January 21, 2025 12:22
@Kiarokh Kiarokh marked this pull request as ready for review January 21, 2025 13:51
… paths

It's unnecessary to specify the file extension
when importing an scss fiel inside another scss file.
It only makes it harder to read.
@Kiarokh Kiarokh force-pushed the markdown-inline-elements branch from a26b80b to b41eb24 Compare January 21, 2025 13:54
@@ -1,3 +1,4 @@
img {
max-width: 100%;
border-radius: 0.25rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't stricktly necessarily or related to this PR. But since everything else is a chore I wouldn't get a release without a fix

LucyChyzhova
LucyChyzhova previously approved these changes Jan 21, 2025
@Kiarokh Kiarokh force-pushed the markdown-inline-elements branch from c3f392b to 6711381 Compare January 21, 2025 14:23
@Kiarokh Kiarokh merged commit d3d7b16 into main Jan 21, 2025
12 checks passed
@Kiarokh Kiarokh deleted the markdown-inline-elements branch January 21, 2025 14:48
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.79.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants