Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cargo-manifest to 0.18 #289

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

coolreader18
Copy link
Contributor

Now doesn't error when resolver = "3" is set.

@milesj
Copy link

milesj commented Jan 12, 2025

@LukeMathWalker This is a blocker for rust 1.84 builds.

@LukeMathWalker LukeMathWalker merged commit 6b08996 into LukeMathWalker:main Jan 12, 2025
4 checks passed
@LukeMathWalker
Copy link
Owner

Released in 0.1.69 ✅

@NixFey
Copy link

NixFey commented Jan 12, 2025

@LukeMathWalker This release seems to have broken builds for me. Is that an expected regression? I can open a new issue for this if you'd prefer 🙂, or could totally just be user error. No changes were made to my Cargo.toml since the last successful build last night

Edit: When posted, I was using Rust 1.83. I have since confirmed that this failure also happens on 1.84

#29 0.913 warning: unused manifest key: bin.0.plugin
#29 0.918 error: failed to parse manifest at `/app/Cargo.toml`
#29 0.918 
#29 0.918 Caused by:
#29 0.918   the target `ProjectName` is a binary and can't have any crate-types set (currently "bin")```

@yurado
Copy link

yurado commented Jan 12, 2025

@NixFey the same thing is happening to my builds.

@yurado
Copy link

yurado commented Jan 12, 2025

I opened #290 to track this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants