Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Add setSegments, Playback State Properties & Refactor Default Mode; fix: Prevent Redundant stop Event #55

Merged
merged 14 commits into from
Nov 28, 2023

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Nov 21, 2023

Description

feat: 🎸 add setSegments method & segments config.
feat: 🎸 isPlaying, isPaused, isStopped properties
refactor: rename default mode to forward
fix: 🐛 prevent stop event from triggering if playback is already stopped.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 5a3fac1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/dotlottie-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 19.41 KB (+2.17% 🔺) 389 ms (+2.17% 🔺) 170 ms (+12.14% 🔺) 558 ms
@lottiefiles/dotlottie-web WASM 103.82 KB (0%) 2.1 s (0%) 0 ms (+100% 🔺) 2.1 s

@theashraf theashraf marked this pull request as ready for review November 22, 2023 07:59
@theashraf theashraf changed the title feat: 🎸 segments feat: 🎸 Add setSegments, Playback State Properties & Refactor Default Mode; fix: Prevent Redundant stop Event Nov 28, 2023
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@theashraf theashraf merged commit 82c01b6 into main Nov 28, 2023
4 checks passed
@theashraf theashraf deleted the feat/segments branch December 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants