Make fields method optional #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log1x
reviewed
Dec 31, 2024
src/Builder.php
Outdated
| @@ -99,7 +99,7 @@ public function addPartial(string $partial): self | |||
| } | |||
|
|
|||
| if (! is_a($partial, FieldsBuilder::class)) { | |||
| throw new InvalidArgumentException('The partial must return an instance of Builder.'); | |||
| return $this; | |||
There was a problem hiding this comment.
Is there an instance where you'd be using partials when not using the fields builder?
🔥 Remove unnecessary `Field` contract 🎨 Tidy up code
Log1x
added a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the proposal mentioned in issue #297 to make the fields method optional in the definitions of blocks, options, etc.