Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(packaging/macos)!: remove macports support #3506

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 2, 2025

Description

This PR will remove support for the Portfile (CI is always having issues with macports).

TODO (future PR):

  • ensure coverage report is properly generated and uploaded
  • adjust coverage labels if needed
  • drop coverage on AppImage, possibly

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the build/packaging/macos/remove-macports-support branch 2 times, most recently from 7fbc934 to 61745e8 Compare January 2, 2025 04:30
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.87%. Comparing base (b662b8e) to head (d79f153).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3506     +/-   ##
========================================
  Coverage    7.87%   7.87%             
========================================
  Files          90      90             
  Lines       15803   15803             
  Branches     7487    7487             
========================================
  Hits         1244    1244             
- Misses      12133   14080   +1947     
+ Partials     2426     479   -1947     
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/packaging/macos/remove-macports-support branch 15 times, most recently from fc1ce82 to d3259f6 Compare January 3, 2025 02:10
@ReenigneArcher ReenigneArcher force-pushed the build/packaging/macos/remove-macports-support branch 3 times, most recently from 5b508f6 to c74688e Compare January 7, 2025 23:26
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 7, 2025 23:27
@ReenigneArcher ReenigneArcher force-pushed the build/packaging/macos/remove-macports-support branch from c74688e to 3ded04c Compare January 7, 2025 23:32
@ReenigneArcher ReenigneArcher force-pushed the build/packaging/macos/remove-macports-support branch from 3ded04c to d79f153 Compare January 7, 2025 23:52
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 7, 2025 23:53
Copy link

sonarqubecloud bot commented Jan 8, 2025

@ReenigneArcher ReenigneArcher merged commit df0bc3f into master Jan 8, 2025
37 checks passed
@ReenigneArcher ReenigneArcher deleted the build/packaging/macos/remove-macports-support branch January 8, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant