Implement Layout Backgrounds #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
enhancement
Closed
CryZe
force-pushed
the
layout-background
branch
2 times, most recently
from
c1aea54 to
77a1586
Compare
This implements background for the layouts. This is a lot more involved than what it would seem. Part of it is a huge refactoring that changes all layout states to be truly absolute. Previously they only included image changes whenever an image changes. We did this because we didn't want to serialize all the image data on every single frame. The new approach is to have a cache for the images and only serialize the image IDs. The image IDs are SHA-256 hashes, which allow deduplicating the images as well.
CryZe
force-pushed
the
layout-background
branch
from
77a1586 to
fe79282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements background for the layouts. This is a lot more involved than what it would seem. Part of it is a huge refactoring that changes all layout states to be truly absolute. Previously they only included image changes whenever an image changes. We did this because we didn't want to serialize all the image data on every single frame. The new approach is to have a cache for the images and only serialize the image IDs. The image IDs are SHA-256 hashes, which allow deduplicating the images as well.