livesplit-hotkey: Add Hook::new_consuming on macOS #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmandry
changed the title
tmandry
changed the title
CryZe
added
enhancement
CryZe
requested changes
Jan 16, 2024
There was a problem hiding this comment.
The original LiveSplit actually had a setting for this, so it would make sense for this crate to support this feature as well. We probably can't make it work on all platforms, but we could always fall back to the other implementation if necessary. I'll push some more changes that at least ensures that every platform has the same API later today.
|
Alright, I rebased your changes onto the new API introduced in #757 |
tmandry
force-pushed
the
new-consuming
branch
from
7313255 to
30d8d45
Compare
tmandry
force-pushed
the
new-consuming
branch
from
30d8d45 to
365573b
Compare
CryZe
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was also requested in #710 for Windows, so there is some demand for it, though I recognize it diverges from the crate's original use case. If it's not something you want to support I can make a bespoke implementation elsewhere, but this happened to be the cleanest implementation/API I could find of a global shortcut library for macOS.
The API puts the choice of consuming or not on the Hook because it allows us to mark non-consuming hooks listen-only, which removes them as a potential bottleneck from the system input pipeline. I think this is probably desirable for your use case but I'm not certain.
After making this change I verified locally that both
newandnew_consumingwork as expected, on macOS 13.5.2.