Iterating through addresses matching a signature #103
Conversation
src/signature.rs
Outdated
| (addr, len): (impl Into<Address>, u64), | ||
| addr: impl Into<Address>, | ||
| len: u64, |
There was a problem hiding this comment.
It would be better to keep the addr and len grouped into a single range tuple, not separate them and force every caller to separate them.
There was a problem hiding this comment.
I've reintroduced the range tuple as suggested. Thinking about it, it is also better as it doesn't break already written code.
src/signature.rs
Outdated
| fn scan_process_range<'a>( | ||
| &'a self, | ||
| process: &'a Process, | ||
| range: (impl Into<Address>, u64), | ||
| ) -> impl Iterator<Item = Address> + 'a; |
There was a problem hiding this comment.
I don't understand why this one returns an iterator. The name does not imply that.
There was a problem hiding this comment.
The main idea is having 2 functions, one that returns an iterator of addresses matching the signature, and another that basically stops at the first match.
I'm open to suggestions on this one, honestly.
There was a problem hiding this comment.
Sure but the name is leftover from the previous implementation which did not return an iterator. So ideally we have something like scan_once / scan_iter or so.
There was a problem hiding this comment.
I like scan_once / scan_iter. I'll refactor the code to have those functions instead.
src/signature.rs
Outdated
| } | ||
|
|
||
| /// Trait that provides scanning methods for the `Signature` type. | ||
| pub trait SignatureScanner { |
There was a problem hiding this comment.
I thought having a trait could allow for implementation of custom signature scanning functions. But if you find this unnecessary, this can be removed.
There was a problem hiding this comment.
I think we only need the trait whenever someone actually abstracts over it (if we have multiple in asr for example)
src/game_engine/unreal/mod.rs
Outdated
| @@ -217,7 +220,7 @@ impl UClass { | |||
| &'a self, | |||
| process: &'a Process, | |||
| module: &'a Module, | |||
| ) -> impl FusedIterator<Item = UProperty> + '_ { | |||
| ) -> impl FusedIterator<Item = UProperty> + 'a { | |||
There was a problem hiding this comment.
uhhh it really shouldn't. Probably leftover data or clippy lints that stayed behind. Weird, I admit lol
This reimplements the signature scanner in order to allow it to return an iterator of addresses matching the signature provided, whereas previously the scan would invariably stop at the first match.
Returning an iterator has several advantages in case more than 1 match is expected, for example it allows the caller to select the target address based on a closure.
For convenience, two more additions have been made:
scanfunction has been added, which essentially provides the same behaviour before the present PR. This allows for simpler scenarios to just stop the iterator at the first matching addressSignatureScannertrait has been implemented forSignature<N>and for thescanandscan_process_rangefunctions. This is more for convenience for now, but could allow for passing anySignature<N>in functions if needed