Support displaying a Custom Variable #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKnauth
force-pushed
the
CustomVariable
branch
from
2d81abd to
ab308c1
Compare
wooferzfg
reviewed
Jan 27, 2025
| this.chkCustomVariable.Name = "chkCustomVariable"; | ||
| this.chkCustomVariable.Size = new System.Drawing.Size(149, 17); | ||
| this.chkCustomVariable.TabIndex = 3; | ||
| this.chkCustomVariable.Text = "Custom Variable"; |
There was a problem hiding this comment.
Is it possible to add a tooltip to explain this setting?
It's not clear that this is only for the Auto Splitting Runtime for autosplitters that support custom variables, and also that you need to put the variable name where you'd normally put the text
There was a problem hiding this comment.
Either that or make the labels clearer ("Autosplitter Custom Variable" for the checkbox, and rename the Text2 label to "Custom Variable Name" if the checkbox is checked)?
There was a problem hiding this comment.
Okay, I've added a ToolTip and made it rename the Text2 label if the checkbox is checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion PR to LiveSplit/LiveSplit#2528. Allows a text component to display the value of a Custom Variable, with a checkbox in the settings.