Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master.jinja2: drop the device_type block #184

Closed
wants to merge 1 commit into from

Conversation

liuyq
Copy link
Contributor

@liuyq liuyq commented Apr 7, 2022

use the device_type variable to define the device type in master.jinja2.
This needs the device file names here to be the same as the device type
defined in the lava instances.

Note:
1. devices/hi6220-hikey is changed to devices/hi6220-hikey-r2
2. defined lava_device_type for corner cases like the qemu devices
they need to set the lava_device_type correctly in their own device files
3. the DEVICE_TYPE should be changed to use device_type instead,
but it could be done in a separate change

Signed-off-by: Yongqin Liu [email protected]

@liuyq
Copy link
Contributor Author

liuyq commented Apr 11, 2022

devices/i386 is another special case

use the device_type variable to define the device type in master.jinja2.
This needs the device files here to be the same as the device type
defined in the lava instances.

Note:
    1. devices/hi6220-hikey is changed to devices/hi6220-hikey-r2
    2. defined lava_device_type for corner cases like the qemu and i386 devices
       they need to set the lava_device_type correctly in their own device files
    3. the DEVICE_TYPE should be changed to use device_type instead,
       but it could be done in a separate change

Signed-off-by: Yongqin Liu <[email protected]>
@liuyq
Copy link
Contributor Author

liuyq commented Apr 12, 2022

As talked with @roxell , this change does not resolve any problems, so let's keep the code like it is now.
For the problem with DEVICE_TYPE, it's done with the PR here #185.
so let me close this PR for now.

@liuyq liuyq closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant