Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused symbols #1971

Closed
wants to merge 6 commits into from
Closed

Conversation

giovannism20
Copy link
Member

@giovannism20 giovannism20 commented Nov 23, 2023

Removed all occurrences of:

  • unused import
  • unused local variable
  • unused private method
  • unused private property
  • unused parameter

@giovannism20 giovannism20 marked this pull request as draft November 23, 2023 22:22
Signed-off-by: Giovanni Martins <[email protected]>
throw new LibresignException($this->l10n->t('Invalid data to sign file'), 1);
}
$this->validateHelper->canRequestCode($signRequest);
$libreSignFile = $this->fileMapper->getById($signRequest->getFileId());
$this->validateHelper->fileCanBeSigned($libreSignFile);
$this->signFileService->requestCode($signRequest, $user);
$message = $this->l10n->t('The code to sign file was successfully requested.');
} catch (SmsTransmissionException $e) {
} catch (SmsTransmissionException) {
// There was an error when to send SMS code to user.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this comment @vitormattos

Signed-off-by: Giovanni Martins <[email protected]>
@giovannism20 giovannism20 changed the title Removed unused symbols - unused local variable Removed unused symbols Nov 23, 2023
Signed-off-by: Giovanni Martins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant