Fix LD_LIBRARY_PATH update

[nvdias0]

After [065d3f5], LD_LIBRARY_PATH is not updated, even when there are *.so inside $addon/lib dirs.

Changing LD_LIBRARY_PATH in a set of code between parenthesis will keep the change only inside that scope.
I propose replacing the parenthesis as follows.

[vpeter4]

I would go with this (no need to save all the files in variable because they don't matter).
Also maxdepth parameter is global and must be used early.

[ -d "${addon}" ] && file="$(find ${addon} -maxdepth 1 ! -type d -name '*.so*' -print -quit)" && [ -n "$file" ] && LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${addon}"
or
[ -d "${addon}" ] && file="$(find -L ${addon} -maxdepth 1 -type f -name '*.so*' -print -quit)" && [ -n "$file" ] && LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${addon}"

[nvdias0]

I would go with this (no need to save all the files in variable because they don't matter). Also maxdepth parameter is global and must be used early.

[ -d "${addon}" ] && file="$(find ${addon} -maxdepth 1 ! -type d -name '*.so*' -print -quit)" && [ -n "$file" ] && LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${addon}" or [ -d "${addon}" ] && file="$(find -L ${addon} -maxdepth 1 -type f -name '*.so*' -print -quit)" && [ -n "$file" ] && LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${addon}"

I've proposed this PR to solve the EXPORT not being properly applied, making a simple syntax adjustment by exchanging the "(...)" for a "&&".
But the changes you proposed are fine with me.

[heitbaum]

I have tested and it is now adding the “lib” directories with .so* files.

• cross reference [RFE] enable lib.private via RPATH #7602

[heitbaum]

@nvdias0 please revert the commit you just pushed. No need to sync this PR up to master.

[nvdias0]

@nvdias0 please revert the commit you just pushed. No need to sync this PR up to master.

I'm sorry, but I don't understand. And I believe I've just deleted the wrong branch.

[heitbaum]

@nvdias0 please revert the commit you just pushed. No need to sync this PR up to master.

I'm sorry, but I don't understand. And I believe I've just deleted the wrong branch.

There are 2 commits in this branch, the second on e “Merge …” occurred when a sync to master was done. This is the commit that you will need to drop.

[timhae]

@nvdias0 please revert the commit you just pushed. No need to sync this PR up to master.

I'm sorry, but I don't understand. And I believe I've just deleted the wrong branch.

checkout your branch, git reset --hard HEAD~1 and git push -f

[nvdias0]

@nvdias0 please revert the commit you just pushed. No need to sync this PR up to master.
checkout your branch, git reset --hard HEAD~1 and git push -f

Done.
Thank you.

[nvdias0]

Sorry for the "noobish" question - is my 1st PR into LibreELEC.

I understand I can press the delete button. Right ?

And even delete my fork ?

thanks

[heitbaum]

Sorry for the "noobish" question - is my 1st PR into LibreELEC.

I understand I can press the delete button. Right ?

And even delete my fork ?

thanks

Correct on both.