-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep addon introduced private shared libraries private to the addon #8342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heitbaum
added
IMPROVEMENT
ADDONS
WORK IN PROGRESS
MERGE BLOCKED
CLEANUP
LE 12.0
labels
Nov 19, 2023
heitbaum
force-pushed
the
lib.private
branch
from
November 30, 2023 13:24
1487c99
to
bc154f6
Compare
heitbaum
force-pushed
the
lib.private
branch
2 times, most recently
from
December 1, 2023 10:10
4ebd31b
to
bcea9ce
Compare
Addressed the |
This was referenced Dec 2, 2023
Merged
… private dotnet directory
The libsockets shared library includes plugins that are dlopened using LD_LIBRARY_PATH unless a plugin directory is set in the code (this is not the case with ttyd.) Thus libwebsockets-evlib_uv.so is not found. So use LD_LIBRARY_PATH to find the plugin.
CvH
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 3 specific areas:
'$ORIGIN/../lib.private'
. This keeps the shared libraries from polluting the LD_LIBRARY_PATH.This PR includes that addons I’m regularly using.
LD_LIBRARY_PATH='/usr/lib:/usr/lib/pulseaudio'
Some historical background of the following error if some one has it?
The code written in a6cd2720475ac71f1ce6a475d3ad7c54a6e40ecb checks for lib directories with .so files. It seems that the
find: /usr/lib/kodi/addons/*/lib: No such file or directory
does not have any addons using this format, peripheral.joystick has the shared libraries located at it’s addon directory.See