fix: fix issue #19

Read props at render time, instead of in the constructor. That way if props change we're always reading the latest values.
LeoNero · Oct 7, 2021 · 463b134 · 463b134
1 parent b867091
commit 463b134
Showing 1 changed file with 17 additions and 26 deletions.
diff --git a/src/index.js b/src/index.js
@@ -13,28 +13,6 @@ class Zoom extends Component {
       mouseY: null,
     }
 
-    const {
-      height,
-      img,
-      transitionTime,
-      width,
-    } = props
-
-    this.outerDivStyle = {
-      height: `${height}px`,
-      width: `${width}px`,
-      overflow: 'hidden',
-    }
-
-    this.innerDivStyle = {
-      height: `${height}px`,
-      backgroundRepeat: 'no-repeat',
-      backgroundPosition: 'center',
-      backgroundSize: 'auto 100%',
-      transition: `transform ${transitionTime}s ease-out`,
-      backgroundImage: `url('${img}')`,
-    }
-
     this.imageRef = createRef()
 
     this.handleMouseOver = this.handleMouseOver.bind(this)
@@ -85,17 +63,30 @@ class Zoom extends Component {
       zoom,
     } = this.state
 
-    const {
-      zoomScale,
-    } = this.props
+    const { zoomScale, height, width, img, transitionTime } = this.props
 
     const transform = {
       transformOrigin: `${mouseX}% ${mouseY}%`,
     }
 
+    const outerDivStyle = {
+      height: `${height}px`,
+      width: `${width}px`,
+      overflow: "hidden",
+    };
+
+    const innerDivStyle = {
+      height: `${height}px`,
+      backgroundRepeat: "no-repeat",
+      backgroundPosition: "center",
+      backgroundSize: "auto 100%",
+      transition: `transform ${transitionTime}s ease-out`,
+      backgroundImage: `url('${img}')`,
+    };
+
     return (
       <div
-        style={this.outerDivStyle}
+        style={outerDivStyle}
         onMouseOver={this.handleMouseOver}
         onMouseOut={this.handleMouseOut}
         onMouseMove={this.handleMouseMovement}