-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stax Support #4
Stax Support #4
Conversation
…o toggle setting is not called)
I did the SIA-02 (potential out of bounds write) and SIA-03 (blind signing enabled by default) changes requested in the audit. I made there be an option to enable hash signing which is disabled by default. I also fixed the errors in the APDU documentation, and replaced the tutorial with a link to our newer one which is much more detailed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments (and we should be able to deploy the app):
- minor lint issue to fix
- I'm not a designer but the Stax icon/glyph could be improved (one for dashboard 32x32 and one for app 64x64)
https://developers.ledger.com/docs/device-app/deliver/deliverables/icons#stax-template
Fixed the linter issue and the icons look much better now! |
@chris124567 |
Checklist
develop
This PR:
These changes have been reviewed here previously: SiaFoundation#3