refactor : 로또 도메인 리팩토링 진행 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @this-is-spear 님, 진행하시느라 고생하셨어요! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
============================================
- Coverage 73.33% 72.46% -0.87%
+ Complexity 23 22 -1
============================================
Files 11 11
Lines 75 69 -6
Branches 9 10 +1
============================================
- Hits 55 50 -5
+ Misses 20 19 -1
☔ View full report in Codecov by Sentry. |
doxxx93
reviewed
Nov 8, 2023
Comment on lines
+3
to
+5
| sealed class LottoGame(val numbers: LottoNumbers) { | ||
| class Manual(manualNumbers: LottoNumbers) : LottoGame(manualNumbers) | ||
| class Auto(autoNumbers: LottoNumbers) : LottoGame(autoNumbers) |
There was a problem hiding this comment.
이런 방법을 패턴 매칭이라 하는군요!! 😲
doxxx93
approved these changes
Nov 8, 2023
Comment on lines
+9
to
+11
| val manualGames = manualNumbers.map { LottoGame.Manual(it) }.toList() | ||
| val autoGames = autoNumbers.map { LottoGame.Auto(it) }.toList() | ||
| val tickets = (manualGames + autoGames).chunked(5).map { LottoTicket(it) } |
songkg7
approved these changes
Nov 10, 2023
|
이 PR 을 마지막으로 마무리할게요~ 1달여남짓 진행하셨는데 수고하셨습니다 👏 merge 처리는 추후 제가 해놓을게요~! |
songkg7
merged commit 2148c01
into
Learning-Is-Vital-In-Development:main
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 구현 내용
값 객체가 아닌 경우를 제외하고 단방향으로 의존 할 수 있도록 코드를 리팩토링 합니다.
LottoApp에서LottoGame의 의존도를 없애고LottoTickets,LottoTicket에 의존하도록 설정해 응집력을 조금 높였습니다.LottoTicket은 최소 하나 이상 다섯 개 이하까지 포함될 수 있도록 검증했습니다.
LottoTicket에 올바른 값이 포함되도록 테스트 코드를 작성했습니다.LottoGame은 이제부터 클래스 타입으로 비교하게 됩니다.LottoGame하위 클래스를 생성해 인스턴스 타입으로 비교할 수 있도록 변경했습니다. 로또 타입은 행위의 결과로 프로퍼티에 존재해도 됐지만 변경될 가능성이 적고 각 유형마다 추가될 행위들이 다르다고 판단했습니다. 각 클래스마다generate메서드를 만들면 어떨까요 ㅎㅎ🤔 논의하고 싶은 내용 / 질문 등
단방향으로 의존 할 수 있도록 코드를 리팩토링 하고 싶었지만
LottoTickets<-LottoTickt<-LottoGame이였지만 방법을 찾지 못했습니다. 어떻게 하면 좋을까용?