-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce boxed methods for insertion. #669
base: main
Are you sure you want to change the base?
Conversation
Once you add a note to RELEASE.md I'll merge this in :) Thanks! I think this is a bit clearer / less messy than |
Finalizing release notes now (suspecting this would be under 0.16.1 as a minor push?), was thinking, should this be listed in the readme as a feature? Especially since it's prime use case is allowing serialized types to be imputed? |
Once we have a full test / example for serialization, yes please to putting it in the README. Until then, we shouldn't make promises that aren't tested :) Please feel free to add anything else required to fix #620: this is a feature I actively want. |
Sorry for the late response, have been busy with life and all. Besides an example/test (which personally, I'm semi-confused on it due to the ways it can actually be implemented being so vast), that is everything needed for allowing serializing. At best I might do a test that tests it serde's everything correctly. |
Sounds good. I'm happy to merge this as soon as there's a simple release note entry then. An end-to-end example + integration test would be ideal in the long-run: this is critical functionality to teach and test. |
PR introduces additional methods that allow using boxed versions of the traits directly.
Previous methods have been adapted to use the boxed versions underlying, and the boxed methods run all the (previous) logic to them.
Relevant issue: #620