feat: Implement Dynamic Daily Reset for DailyPlayerStat #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manlikeHB
requested changes
Mar 5, 2025
onchain/src/contracts/dewordle.cairo
Outdated
Comment on lines
162
to
174
| let current_timestamp = get_block_timestamp(); | ||
| let last_attempt_timestamp = daily_stat.last_attempt_timestamp; | ||
|
|
||
| if last_attempt_timestamp < self.end_of_day_timestamp.read() - SECONDS_IN_A_DAY { | ||
| daily_stat = | ||
| DailyPlayerStat { | ||
| player: caller, | ||
| attempt_remaining: 6, | ||
| has_won: false, | ||
| won_at_attempt: 0, | ||
| last_attempt_timestamp: current_timestamp, | ||
| }; | ||
| } |
There was a problem hiding this comment.
move this to the top of the submit_guess function, also you're not updating the daily player stat when it's a new day.
onchain/tests/test_dewordle.cairo
Outdated
Comment on lines
498
to
513
| #[test] | ||
| fn test_get_player_daily_stat_new_player() { | ||
| let contract_address = deploy_contract(); | ||
| let dewordle = IDeWordleDispatcher { contract_address }; | ||
|
|
||
| // Get stats for a player that hasn't played yet | ||
| let random_player = starknet::contract_address_const::<0x456>(); | ||
| let daily_stat = dewordle.get_player_daily_stat(random_player); | ||
|
|
||
| // Verify default values | ||
| assert(daily_stat.player == random_player, 'Wrong player address'); | ||
| assert(daily_stat.attempt_remaining == 6, 'Should have 6 attempts'); | ||
| assert(!daily_stat.has_won, 'has_won should be false'); | ||
| assert(daily_stat.won_at_attempt == 0, 'won_at_attempt should be 0'); | ||
| assert(daily_stat.last_attempt_timestamp == 0, 'Timestap should be 0'); | ||
| } |
onchain/src/contracts/dewordle.cairo
Outdated
| }; | ||
| self.daily_player_stat.write(caller, new_daily_stat); | ||
| Option::None | ||
| return Option::None; |
There was a problem hiding this comment.
Suggested change
| return Option::None; | |
| Option::None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR introduces a mechanism to track each player's last attempt timestamp using last_attempt_timestamp inside the DailyPlayerStat struct. This ensures that player stats reset dynamically on their first attempt of a new day. The submit_guess function now checks if last_attempt_timestamp is from a previous day—if so, it resets DailyPlayerStat; otherwise, it proceeds normally. Additionally, last_attempt_timestamp updates on every guess submission. Unit tests have been added to verify correct behavior.
Related Issue
Closes #234
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)Update your CONTRIBUTING.md to reference the template
Documentation update
Code refactoring
Performance improvement
Test update
Build/CI pipeline change
Other (please describe):
Checklist
I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
Any dependent changes have been merged and published in downstream modules.
Screenshots/Recordings
Additional Context
Testing Instructions
Run "scarb test" while in the onchain directory