Skip to content

Commit

Permalink
Move Bazel action state updates to BGT.
Browse files Browse the repository at this point in the history
(cherry picked from commit e3b3fa3)
  • Loading branch information
Googler authored and mai93 committed Mar 11, 2024
1 parent 1f46b8f commit bc05643
Show file tree
Hide file tree
Showing 9 changed files with 53 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,9 @@ private static String menuName(BuildSystemName buildSystemName) {
public boolean isDumbAware() {
return true;
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ public final void actionPerformed(AnActionEvent anActionEvent) {

protected void updateForBlazeProject(Project project, AnActionEvent e) {}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.BGT;
}

protected abstract void actionPerformedInBlazeProject(Project project, AnActionEvent e);

private boolean compatibleBuildSystem(Project project) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,9 @@ public final void update(AnActionEvent e) {
}

protected void updateForBlazeProject(Project project, AnActionEvent e) {}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.BGT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -283,5 +283,10 @@ public synchronized void actionPerformed(AnActionEvent anActionEvent) {
table.revalidate();
table.repaint();
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import com.intellij.notification.NotificationGroup;
import com.intellij.notification.NotificationType;
import com.intellij.notification.Notifications;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.Presentation;
import com.intellij.openapi.application.ApplicationNamesInfo;
Expand Down Expand Up @@ -117,4 +118,10 @@ private static void showPopupNotification(Project project) {
protected QuerySyncStatus querySyncSupport() {
return QuerySyncStatus.SUPPORTED;
}

@Override
public ActionUpdateThread getActionUpdateThread() {
// Not clear what `showPopupNotification` does and why.
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ public void actionPerformed(AnActionEvent e) {
public void update(AnActionEvent event) {
event.getPresentation().setEnabled(stopHandler != null);
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}

/** A composite filter composed of a modifiable list of custom filters. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ public boolean isSelected(AnActionEvent event) {
public void setSelected(AnActionEvent event, boolean flag) {
configuration.setAutoscrollToConsole(flag);
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}

private static class OpenInConsoleAction extends BaseNavigateToSourceAction {
Expand Down Expand Up @@ -234,6 +239,11 @@ public void setSelected(AnActionEvent event, boolean showWarnings) {
reload();
}
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ public void update(AnActionEvent e) {
.setText(String.format("Import %s Project...", Blaze.defaultBuildSystemName()));
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}

private static void createFromWizard(
BlazeProjectCreator blazeProjectCreator, WizardContext wizardContext) {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.google.idea.common.actions.ReplaceActionHelper;
import com.intellij.debugger.actions.HotSwapAction;
import com.intellij.openapi.actionSystem.ActionManager;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.impl.ActionConfigurationCustomizer;
Expand Down Expand Up @@ -60,4 +61,9 @@ public void update(AnActionEvent e) {
&& BlazeHotSwapManager.findHotSwappableBlazeDebuggerSession(e.getProject()) != null;
e.getPresentation().setEnabled(canHotSwap);
}

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.BGT;
}
}

0 comments on commit bc05643

Please sign in to comment.