Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running a game added manually it would close #159

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Bender22
Copy link
Contributor

@Bender22 Bender22 commented Jun 19, 2024

Description

Fixed that when running a game on windows that had been added manually it would close after a few seconds

Changes

+ Added []
- Removed [...]
= Changed [src-tauri/src/launchers/mod.rs]
+ Added [...]

Affected Operating System(s)

Windows(8, 10, 11)

@p0ryae
Copy link
Member

p0ryae commented Jun 19, 2024

Thanks for opening this PR.

First off, can you please set the target branch to nightly instead of main? This change needs to be in the nightly branch first, and then will be merged to main for a future release.

@Bender22 Bender22 changed the base branch from main to nightly June 20, 2024 09:31
@Bender22
Copy link
Contributor Author

Thank you for this application.
No problem target branch set to nightly

@p0ryae
Copy link
Member

p0ryae commented Jun 21, 2024

Although I can't replicate the same issue as you for a custom game, I will still consider merging.

Please fix the rust formatting for the mod.rs file first, then I will merge.

@p0ryae p0ryae merged commit fa42628 into Lazap-Development:nightly Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants