Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Address pipeline warnings #340

Merged
merged 5 commits into from
Feb 6, 2024
Merged

🧹 Address pipeline warnings #340

merged 5 commits into from
Feb 6, 2024

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Feb 5, 2024 •
edited
Loading

In this PR

  • Addressing some of the warnings raised in the CI/CD - adding some of the environment variables to globalPassThroughEnv in turbo.json and updating version of actions/setup-node to v4 and pnpm/action-setup to v2.4.0 get rid of pnpm/action-setup in favor of using corepack enable - see this issue

Before

Screenshot 2024-02-05 at 3 28 42 PM

After

Screenshot 2024-02-05 at 3 47 25 PM

@ryandgoulding ryandgoulding merged commit da6a148 into main Feb 6, 2024
3 checks passed
@ryandgoulding ryandgoulding deleted the pipeline-fixes branch February 6, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandgoulding ryandgoulding ryandgoulding approved these changes

@sirarthurmoney sirarthurmoney Awaiting requested review from sirarthurmoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjakubnanista @ryandgoulding