-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oft-solana): create new instruction for renouncing freeze authority #1144
Draft
nazreen
wants to merge
5
commits into
main
Choose a base branch
from
nazreen/oft-solana/renounce-freeze
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziming-zung
previously approved these changes
Jan 9, 2025
The changes in the anchor program look good to me. |
HansonYip
reviewed
Jan 9, 2025
HansonYip
reviewed
Jan 9, 2025
examples/oft-solana/programs/oft/src/instructions/renounce_freeze.rs
Outdated
Show resolved
Hide resolved
HansonYip
reviewed
Jan 9, 2025
examples/oft-solana/programs/oft/src/instructions/renounce_freeze.rs
Outdated
Show resolved
Hide resolved
HansonYip
reviewed
Jan 9, 2025
examples/oft-solana/programs/oft/src/instructions/renounce_freeze.rs
Outdated
Show resolved
Hide resolved
nazreen
force-pushed
the
nazreen/oft-solana/renounce-freeze
branch
from
January 9, 2025 09:29
bee739e
to
afde8f3
Compare
Latest Commit Changes:
PR body has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: do not use this code yet as it is
unreviewed andunauditedMotivation
This is for already created OFTs that were deployed with
--only-oft-store true
before #1141 , meaning the Freeze Authority was set to the multisig address, but the intention is to have the Freeze Authority renounced.Changes introduced:
programs/oft/src/instructions/renounce_freeze.rs
lib.rs
) to 'register' the new instruction:tasks/solana/renounceFreeze.ts
program_id_from_env
inprograms/oft/src/lib.rs
since it's not used. The removal of this enablesanchor keys sync
to auto-replace the program id here, thereby removing the manual step we currently require for devs to replace the program id in this file.How to test
Init a new repo with this branch's examples
Build and Deploy program as usual.
To simulate previous case of Freeze Authority being set to the multisig even when in
onlyOftStore
mode, make the following edit increateOFT.ts
:Then, run the create script with
--only-oft-store true
Finally, run the new script:
TODOS
Next Step: updating the
oft
export in@layerzerolabs/oft-v2-solana-sdk
apps/oft/v2/solana/sdk/src/oft.ts
in monorepo to support new renounce freeze instruction, allowing us to just use something like below:Notes:
<MULTISIG_ADDRESS>
should bemintAuthority
the in OFT.json deployment filederiveConnection()