Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants fix #162

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Variants fix #162

merged 3 commits into from
Jan 6, 2025

Conversation

IWHarvey
Copy link
Collaborator

@IWHarvey IWHarvey commented Nov 6, 2024

  • What kind of change does this PR introduce (Bug fix, feature, docs update, ...)?
    Bug fix

  • What is the current behavior?
    The compose fragments variants behaviour described in the readme doesn't seem to function as advertised.

  • What is the new behavior (if this is a feature change)?
    Updated to how I it should work per my reading of the readme

  • Does this PR introduce a breaking change? If so, what actions will users need to take in order to regain compatibility?
    No?

Checklists

All submissions

  • Have you followed the guidelines in our Contributing document?
  • Is this PR targeting the develop branch, and the branch rebased with commits squashed if needed?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New feature and bug fix submissions

  • Has your submission been tested locally?
  • Has documentation such as the README been updated if necessary?
  • Have you linted your new code (using rubocop and markdownlint), and are not introducing any new offenses?

@IWHarvey IWHarvey changed the base branch from master to develop November 6, 2024 14:48
@IWHarvey IWHarvey marked this pull request as ready for review December 9, 2024 10:18
@sichapman sichapman merged commit ca64200 into develop Jan 6, 2025
3 checks passed
@sichapman sichapman deleted the variants_fix branch January 6, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants