Skip to content

Commit

Permalink
Remove support for alembic during startup
Browse files Browse the repository at this point in the history
  • Loading branch information
sichapman authored Jan 16, 2025
1 parent a4ec792 commit f893a62
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 87 deletions.
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This repository contains the code for a development environment that can be used
It provides several hooks for applications to take advantage of, including:

- Docker container creation and launching via docker-compose
- Automatic creation of commodity systems such as Postgres or Elasticsearch (with further hooks to allow for initial provisoning such as running SQL, Alembic DB upgrades or Elasticsearch index creation)
- Automatic creation of commodity systems such as Postgres or Elasticsearch (with further hooks to allow for initial provisoning such as running SQL)

## Getting started

Expand Down Expand Up @@ -158,10 +158,6 @@ If you want to spatially enable your database see the following example:

The default Postgres port 5432 will be available for connections from other containers, hostname `postgres-13` or `postgres-17`. Port `5434` (for PG13) or `5435` (for PG17) is exposed for external connections from the host.

**`/manage.py`**

This is a standard Alembic management file - if it exists, then a database migration will be run on every `up` or `reload`. This functionality can be enabled by setting the key `perform_alembic_migration` to `true` in `configuration.yml`. It is recommended however that you do your own migration during app startup.

##### DB2 Community

Note that DB2 Community is exposed on 30002/35002 to avoid port clashes.
Expand Down
3 changes: 0 additions & 3 deletions scripts/commodities.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require_relative 'utilities'
require_relative 'provision_postgres'
require_relative 'provision_alembic'
require_relative 'provision_auth'
require_relative 'provision_hosts'
require_relative 'provision_db2_community'
Expand Down Expand Up @@ -136,8 +135,6 @@ def provision_commodities(root_loc, new_containers)
# Do a fullreset, or docker-compose rm -v -f postgres-13
%w[13 17].each do |postgres_version|
provision_postgres(root_loc, new_containers, postgres_version)
# Alembic, too
provision_alembic(root_loc, postgres_version)
end

# Run app DB2 SQL statements
Expand Down
78 changes: 0 additions & 78 deletions scripts/provision_alembic.rb

This file was deleted.

1 change: 0 additions & 1 deletion snippets/app_configuration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ expensive_startup:
wait_until_healthy:
- compose_service: db2_community
healthcheck_cmd: docker
perform_alembic_migration: true

0 comments on commit f893a62

Please sign in to comment.