Add generate-docker-compose command #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastereng12
approved these changes
May 14, 2024
There was a problem hiding this comment.
@austonst thank you for the contribution, this change totally makes sense!
| if err != nil { | ||
| return fmt.Errorf("failed to generate docker compose file: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
the docker compose file path display here?
mastereng12
added a commit
that referenced
this pull request
May 21, 2024
* node version update (#49) * remove main from ci (#56) * Bump github.com/urfave/cli/v2 from 2.27.1 to 2.27.2 (#55) Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.27.1 to 2.27.2. - [Release notes](https://github.com/urfave/cli/releases) - [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md) - [Commits](urfave/cli@v2.27.1...v2.27.2) --- updated-dependencies: - dependency-name: github.com/urfave/cli/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * password path (#61) * Add generate-docker-compose command (#60) * feat: add Arbitrum config (#62) * add arbitrum config * README * update README * update the arbitrum mainnet --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: cool-developer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Auston Sterling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An initial attempt at #59 , minimal necessary changes but possibly insufficient for full support of the described workflow.
Description
This PR implements a new CLI command,
lagrange-cli generate-docker-compose. The code to generate the docker-compose file is moved into a separate function which the new CLI command calls directly without any usage ofexec.Command("docker", ...). This command can therefore be run inside a docker container along with all the other setup commands.The
deploycommand retains its current behavior of checking for docker image availability, generating the docker-compose file (via the new function), then callingdocker compose -f <file> up -d. Operators accustomed to thedeployworkflow do not need to change their behavior.Limitations
This change makes the workflow described in #59 possible, but potentially clunky and incomplete. In the output
docker-compose_<net>_<l2>_<key>.ymlfile, the volumes are filled in as follows (e.g.):The source path
/root/.lagrange/keypassis the path within the CLI container, but would need to be a path in the base OS. Haven't really thought about the best solution here. Hacky solution for now is to pass the file throughsed:This works for our (Aestus's) use case as we need to pass the docker-compose file through further scripted post-processing anyway (e.g. adding docker network connections) and it's easy to throw a
sedin there. But it certainly feels like there could be a better solution.