Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the signer config #138

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: the signer config #138

merged 3 commits into from
Sep 23, 2024

Conversation

mastereng12
Copy link
Contributor

Context

  • fix the key and password file path missing in the signer
  • considering TLSConfig missing
  • add templates

Reviewers

  • @Lagrange-Labs/lsc-core-dev

@mastereng12 mastereng12 requested a review from a team September 23, 2024 12:42
@mastereng12
Copy link
Contributor Author

@Mergifyio backport release/v1.1.x

@mergify Mergify
Copy link

mergify bot commented Sep 23, 2024 •
edited
Loading

backport release/v1.1.x

✅ Backports have been created

@kashishshah
Copy link
Member

Please update readme to add the new commands

@kashishshah
Copy link
Member

A tab is being created in docker compose file of the attestation node between these two lines under volumes which is not deploying the container
Error: "yaml: line 15: found a tab character that violates indentation"

@kashishshah
Copy link
Member

please add bulk-generate-config-deploy command link to readme

@mastereng12 mastereng12 merged commit 0447937 into develop Sep 23, 2024
3 checks passed
@mastereng12 mastereng12 deleted the config/fix_signer branch September 23, 2024 17:39
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@mastereng12 @mergify
fix: the signer config (#138)
7118cf1 
* fix the signer config

* update README

* minor fix

(cherry picked from commit 0447937)

# Conflicts:
#	cmd/main.go
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
mastereng12 added a commit that referenced this pull request Sep 23, 2024
@mergify @mastereng12
fix: the signer config (backport #138) (#140)
b887a29 
* fix: the signer config (#138)

* fix the signer config

* update README

* minor fix

(cherry picked from commit 0447937)

# Conflicts:
#	cmd/main.go

* fix conflicts

---------

Co-authored-by: Master Engineer <[email protected]>
Co-authored-by: mastereng12 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashishshah kashishshah kashishshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mastereng12 @kashishshah