Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thought I'd make a pull request with my progress updating to 1.21.2.
One thing I've noticed is that the
EntitiesPreRenderCallback
,EntitiesPostRenderCallback
, andPostWorldRenderCallbackV1-3
all have basically direct equivalents in Fabric API'sWorldRenderEvents
class. Is it a good idea to continue to keep these events in Satin? They seem a bit unnecessary and more prone to breakage with custom renderers. Perhaps if you really want to avoid any breaking changes, they could just be deprecated and called from an equivalent Fabric API event listener. Though I don't think it would be unwarranted to have a breaking change for this scale of an update...