End Proyect squad Mariana & Mariel #14
Conversation
There was a problem hiding this comment.
Mariel y Olimpia, me gusto mucho su proyecto y sobre todo el diseño, lo cual es importante resaltarlo, tengo 2 recomendaciones: 1) Tengan cuidado con el uso de 3 maneras de generar estilos porque parecía que se instalaban dos frameworks de diseño y adicional sass, si no van a usar bootstrap entonces borrenlo.
2) Veo componentes super GIGANTES lo cual pueden mejorar modularizando mejor sus componentes.
Su proyecto es muy bueno y en general esta muy genial.
| @@ -0,0 +1,26 @@ | |||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | |||
|
|
|||
There was a problem hiding this comment.
esto esta genial, recuerda siempre tener tu gitignore configurado
| "last 1 chrome version", | ||
| "last 1 firefox version", | ||
| "last 1 safari version" | ||
| ] |
There was a problem hiding this comment.
recuerda que puedes tener dependencias en modo dev
| Learn how to configure a non-root public URL by running `npm run build`. | ||
| --> | ||
| <title>Burger Queen</title> | ||
| <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.0/css/bootstrap.min.css" integrity="sha384-9aIt2nRpC12Uk9gS9baDl411NQApFmC26EwAOH8WgZl5MYYxFfc+NcPb1dKGj7Sk" crossorigin="anonymous"> |
There was a problem hiding this comment.
Si no vaz a usa bootstrapcdn entonces ten cuidado y borralo porque podría tener conflictos.
| <Router> | ||
| <Switch> | ||
| <Fragment> | ||
| <Fragment> | ||
| <Route path ='/' exact component = {IndexApp} /> | ||
| </Fragment> | ||
| <Fragment> | ||
| <Fragment> | ||
| <Route path ='/orden' component={OrderSection}/> | ||
| </Fragment> | ||
| <Fragment> | ||
| <Route path= '/cocina' component= {KitchenSection}/> | ||
| </Fragment> | ||
| <Fragment> | ||
| <Route path = '/historial' component = {HistorialSection}/> | ||
| </Fragment> | ||
| </Fragment> | ||
| </Fragment> | ||
| </Switch> | ||
| </Router> |
There was a problem hiding this comment.
Esto aun lo puedes meter en un componente
| $bqcream: #FCFAE3; | ||
| $bqpink: #FF7BAC; | ||
| $bqgreen: #1EBC9E; | ||
| $btMenu: '../src/Assets/btnMenu.png'; |
There was a problem hiding this comment.
| $bqcream: #FCFAE3; | |
| $bqpink: #FF7BAC; | |
| $bqgreen: #1EBC9E; | |
| $btMenu: '../src/Assets/btnMenu.png'; | |
| $btMenu: '../src/Assets/btnMenu.png'; | |
| $bqcream: #FCFAE3; | |
| $bqpink: #FF7BAC; | |
| $bqgreen: #1EBC9E; |
| render: (id) =>{ | ||
| return <DeleteTwoTone onClick={() => deleteProducto(id)} /> | ||
| }, |
There was a problem hiding this comment.
Esto esta cool
| render: (id) =>{ | |
| return <DeleteTwoTone onClick={() => deleteProducto(id)} /> | |
| }, | |
| render: (id) =>{ | |
| return <DeleteTwoTone onClick={() => deleteProducto(id)} /> | |
| }, |
| ) | ||
| } else { | ||
| return ( | ||
| <div><Select placeholder="Mesa" style={{ width: 175 }} onChange={handleChange} value={carrito.mesa}> |
There was a problem hiding this comment.
dato adicional
| <div><Select placeholder="Mesa" style={{ width: 175 }} onChange={handleChange} value={carrito.mesa}> | |
| <div><Select placeholder="Mesa" style={{ width: 175 }} onChange={()=>{handleChange() secondHandle()}} value={carrito.mesa}> |
| let [carrito,setCarrito]=useState({ | ||
| nombreCliente:"", | ||
| total:0, | ||
| item:[], | ||
| status:false, | ||
| pay:false, | ||
| mesa:"", | ||
| orden: (""+Math.random()).substring(2,7), | ||
| mesero: "" |
There was a problem hiding this comment.
no español
| let [carrito,setCarrito]=useState({ | |
| nombreCliente:"", | |
| total:0, | |
| item:[], | |
| status:false, | |
| pay:false, | |
| mesa:"", | |
| orden: (""+Math.random()).substring(2,7), | |
| mesero: "" | |
| let [carrito,setCarrito]=useState({ | |
| nombreCliente:"", | |
| total:0, | |
| item:[], | |
| status:false, | |
| pay:false, | |
| mesa:"", | |
| orden: (""+Math.random()).substring(2,7), | |
| mesero: "" |
| import React from 'react'; | ||
| import '../NavHeader/NavHeader.scss' | ||
| import Button from '../../Button/Button'; | ||
| import { useHistory } from "react-router-dom"; |
There was a problem hiding this comment.
Esto esta raro de leer
| import React from 'react'; | |
| import '../NavHeader/NavHeader.scss' | |
| import Button from '../../Button/Button'; | |
| import { useHistory } from "react-router-dom"; | |
| import React from 'react'; | |
| import { useHistory } from "react-router-dom"; | |
| import '../NavHeader/NavHeader.scss' | |
| import Button from '../../Button/Button'; | |
| @@ -0,0 +1,26 @@ | |||
| @import '~antd/dist/antd.css'; | |||
|
|
|||
There was a problem hiding this comment.
Sugerencia si vaz usar fuente utiliza google Font, le dará un buen estilo a tu frontend
No description provided.