Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KnitrReportTest: use checkExpectedErrors() #2297

Merged
merged 4 commits into from
Feb 26, 2025
Merged

KnitrReportTest: use checkExpectedErrors() #2297

merged 4 commits into from
Feb 26, 2025

Conversation

labkey-nicka
Copy link
Contributor

Rationale

Switch KnitrReportTest to use checkExpectedErrors() to handle expected client-side errors when test is running.

Changes

  • Utilize checkExpectedErrors(1) to handle expected client-side error.

@labkey-nicka labkey-nicka self-assigned this Feb 25, 2025
@labkey-nicka labkey-nicka merged commit 44fee7d into develop Feb 26, 2025
4 checks passed
@labkey-nicka labkey-nicka deleted the fb_remove_js_error_pause branch February 26, 2025 16:26
@labkey-tchad labkey-tchad mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XingY XingY XingY approved these changes

@labkey-tchad labkey-tchad labkey-tchad approved these changes

Assignees

@labkey-nicka labkey-nicka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@labkey-nicka @XingY @labkey-tchad